What is rsms.me?

alan · April 6, 2024, 2:18am

I loaded up my login page today on a up-to-date self-hosted instance of IN v5 and it just hung while the browser indicated it is busy “Connecting to https://rsms.me”. Is this a new thing? I don’t allow external requests from my IN instance so this will always fail. Any suggestions?

hillel · April 6, 2024, 6:24pm

Hi,

I see a reference to this file in the React app.

@david @ben can we move any files hosted on a third-party site into the codebase, unless we need to load it from them (ie, payment gateways).

github.com

invoiceninja/ui/blob/e63570f72440ac3c58d9351809e8c781c160c34e/index.html#L14


      
          <title>Invoice Ninja</title>
          
          
<meta charset="utf-8" />
          <meta name="viewport" content="width=device-width, initial-scale=1" />
          <meta name="theme-color" content="#000000" />
          <meta
            name="description"
            content="Leading free invoice generator for freelancers and small businesses. Invoice clients, accept payments, track expenses &amp; time billable-tasks online."
          />
          
          
<link rel="stylesheet" href="https://rsms.me/inter/inter.css" />
          <link rel="icon" href="/favicon.ico" />
          <link rel="apple-touch-icon" href="/logo192.png" />
          <link rel="manifest" href="/manifest.json" />
          
          
<script>
            if ('%VITE_IS_HOSTED%' === 'true') {
              const facebookPixelId = '%VITE_FACEBOOK_PIXEL_ID%';
          
          
    const noscriptElement = document.createElement('noscript');

alan · April 10, 2024, 2:51pm

Good to see that you were able to verify that the URL is related to a remote CSS sheet. It would be nice if this small change could be slated for upcoming work. Thanks!

alan · April 16, 2024, 2:41pm

And chance to get some traction on this? Probably from a developer standpoint it is undesirable to depend on 3rd party websites like this. If the external resource goes away for any reason, all InvoiceNinja users will experience the hanging login page.

hillel · April 16, 2024, 2:47pm

Feel free to create an issue on GitHub to track the issue:

alan · April 17, 2024, 3:52am

Created an issue here: External CSS stylesheet dependency on IN v5 login page · Issue #1707 · invoiceninja/ui · GitHub