Issue with custom delimiter on CSV imports

hochdyl · March 8, 2021, 11:48am

Hi,

I’m trying to migrate to ninja my invoices, but I have some problems with the CSV importation.

As you can see in my screenshot, i’m trying to change the default delimiter to “$”.
My CSV is correctly formatted but it looks like the app is not applying my custom delimiter.
The data i’m trying to import is referring to products.

Am I doing it the right way or is it a bug ?

Sorry if someone asked this before, I didn’t find any reference to this bug in the forum.

Best regards,
Dylan

hillel · March 8, 2021, 11:51am

Hi,

The app expects the CSV file to use a comma as the delimiter

hochdyl · March 8, 2021, 11:55am

Hi,

Thanks for your fast reply, so there isn’t any way to change this? As in France we use comma instead of dot for numeric values, some of my columns are not imported so well…

Or maybe you can tell my in which file the comma is defined as the delimiter so I can change this.

hillel · March 8, 2021, 12:02pm

github.com

invoiceninja/invoiceninja/blob/master/app/Services/ImportService.php#L664


}

private function getCsvData($fileName)
{
    $this->checkForFile($fileName);

    if (! ini_get('auto_detect_line_endings')) {
        ini_set('auto_detect_line_endings', '1');
    }

    $csv = Reader::createFromPath($fileName, 'r');
    //$csv->setHeaderOffset(0); //set the CSV header offset
    $stmt = new Statement();
    $data = iterator_to_array($stmt->process($csv));

    if (count($data) > 0) {
        $headers = $data[0];

        // Remove Invoice Ninja headers
        if (count($headers) && count($data) > 4) {
            $firstCell = $headers[0];

hochdyl · March 8, 2021, 12:10pm

It’s working perfectly well, thanks for your help and have a nice day