Documents dont Carry over when Converting Quote to Invoice

texascabinetryco · July 5, 2023, 5:59pm

When a customer converts a quote to an invoice I m having to Reupload the documents to the Invoice.
is there a way to have the invoice link to the quote documents or have the Documents copied to the invoice when converting?

hillel · July 5, 2023, 6:01pm

Hi,

@david can you please advise?

david · July 6, 2023, 12:40am

@hillel

is this the expected functionality?

hillel · July 6, 2023, 7:09am

I’ve checked the v4 code, it looks like if an invoice is cloned or converted to a quote the documents are copied to the new record.

github.com

invoiceninja/invoiceninja/blob/master/app/Ninja/Repositories/InvoiceRepository.php#L971


      
                  'custom_value1',
                  'custom_value2',
                  'discount',
              ] as $field) {
                  $cloneItem->$field = $item->$field;
              }
          
          
    $clone->invoice_items()->save($cloneItem);
          }
          
          
foreach ($invoice->documents as $document) {
              $cloneDocument = $document->cloneDocument();
              $clone->documents()->save($cloneDocument);
          }
          
          
foreach ($invoice->invitations as $invitation) {
              $cloneInvitation = Invitation::createNew($invoice);
              $cloneInvitation->contact_id = $invitation->contact_id;
              $cloneInvitation->invitation_key = strtolower(str_random(RANDOM_KEY_LENGTH));
              $clone->invitations()->save($cloneInvitation);
          }

texascabinetryco · July 11, 2023, 2:12am

For this Client I clicked on Approve on the quote, But the same thing happens when a client clicks on approve.

This is the Converted Quote with the documents:

Here is the Invoice Created from the Conversion: (notice no documents are attached and in the client portal it also shows no documents.

If i click on the quote and select “Client Portal” i see the documents, from there if I click on View invoice there are no documents attached.
QUOTE:

Invoice:

I can Manually upload the same images to the Document section on the Invoice.
and that solves the issue, but I think it should be automatic.