Bug: Company default values not filled in when converting a quotation to invoice

bramdriesen · May 16, 2022, 5:56pm

When converting a quotation to an invoice, in the past it would take the “invoice conditions” value from the company defaults settings, however this is no longer happening.

When creating an invoice from scratch the value is properly being pre-filled.

Steps to reproduce:

Go to settings → Company → Default values and make sure the “invoice conditions” are filled in. (Not sure if it matters but we have default values for both the header and footer for invoices and quotations)
Create an invoice and check that the value is properly being propagated (this is ok)
Create an quotation for a client.
Mark it as sent
In the quotation overview click the 3 dots and select “convert to invoice”
Go to the created invoice and click on edit. The default value is now NOT being filled in. Instead it still contains the conditions of the quotation and you will have to change it manually.

hillel · May 16, 2022, 6:04pm

Hi,

@david can you please advise?

david · May 16, 2022, 10:48pm

Terms from the quote are carried over to the invoice, I believe this is expected functionality.

hillel · May 17, 2022, 4:48am

I believe in v4 if the account has invoice terms they’re used instead.

github.com

invoiceninja/invoiceninja/blob/master/app/Ninja/Repositories/InvoiceRepository.php#L929


  'custom_text_value1',
  'custom_text_value2',
] as $field) {
    $clone->$field = $invoice->$field;
}


if ($quoteId) {
    $clone->invoice_type_id = INVOICE_TYPE_STANDARD;
    $clone->invoice_design_id = $account->invoice_design_id;
    $clone->quote_id = $quoteId;
    if ($account->invoice_terms) {
        $clone->terms = $account->invoice_terms;
    }
    if (! auth()->check()) {
        $clone->is_public = true;
        $clone->invoice_status_id = INVOICE_STATUS_SENT;
    }
}


$clone->invoice_number = $invoiceNumber ?: $account->getNextNumber($clone);
$clone->invoice_date = date_create()->format('Y-m-d');

bramdriesen · May 17, 2022, 6:09am

No it is not. We have different terms for quotations as for invoices. As soon as the quotation is converted to an invoice it should state the invoice terms. This used to work up until a few weeks ago (don’t know exactly when).

david · May 17, 2022, 6:48am

@hillel

We changed this recently so that quote terms move over to the invoice.

Should we add a flag to control the behaviour of this?

hillel · May 17, 2022, 6:54am

That works for me, I think by default we should follow the v4 behavior of using the invoice terms.

david · May 17, 2022, 7:27am

@bramdriesen I believe the functionality will be as you expect by default in the next release.

bramdriesen · May 17, 2022, 8:10am

Awesome! Thanks I will test and let you know if it works as expected

bramdriesen · May 24, 2022, 12:03pm

When will this be deployed to the hosted version? I see it’s still on version v5.3.88-C84 and not the 5.3.89 containing the fix.

david · May 25, 2022, 11:27pm

@bramdriesen

This will be available this coming Sunday, we had to delay last weeks release.

bramdriesen · May 29, 2022, 5:03pm

I just tested this and it is indeed fixed! Many thanks.