Generated Numbers - client_counter

david · January 8, 2021, 10:13am

@peterjm

I can’t recreate this, $client_counter is working for me when i create invoices.

peterjm · January 8, 2021, 5:06pm

@david

Steps to reproduce:

https://demo.invoiceninja.com

Settings> Generated Numbers> Incoives

Set Number Pattern to:
Client Counter:{$client_counter}-Counter:{$counter}

Create a few invoices for different clients. The client_counter shows the same value as counter, where i thought it should be a unique counter for each client invoice count? Or im mis understanding the purpose of client_counter.

counter results

Thanks!

david · January 8, 2021, 10:36pm

Ah so i think you can only have one counter operating at a time.

peterjm · January 10, 2021, 2:17am

@david

ok. Well I tried setting Invoices Number Pattern to the following:
I-{$client_counter} (So that only one counter is operating at a time right?)

However the $client_counter value is still just showing same value as $counter would (it just counts the number of invoices ever created regardless of which client is being invoiced). Shouldn’t the $client_counter be showing the number of invoices for the client being invoiced?

Otherwise im not understanding its purpose of client_counter. How is it different from counter? My assumption was that it should be based on a new counter per client ID (which I would find really useful because i could have each invoice count per client ID and each client would know the total number of invoices they had)

Thanks,

Peter

david · January 10, 2021, 10:31am

@peterjm

I think i see a bug here, i’ll check in a fix for this.

david · January 10, 2021, 10:46am

@peterjm a fix for this is in the v5-develop branch,

please note you must use {client_id_number} with {client_counter} for it to work.

peterjm · January 16, 2021, 4:40am

Can confirm this is working properly for me now in v5.0.47-C38 when i use both {$client_id_number} with {$client_counter}

david · January 16, 2021, 10:02am

Thanks for the update @peterjm!

peterjm · February 10, 2021, 5:59pm

Running into this new error on v5.1.5-C41

When i add $number as the error suggests it still shows up.

hillel · February 10, 2021, 6:41pm

Thanks for reporting this, I’ll take a look

hillel · February 15, 2021, 8:01pm

I think the problem here (in part at least) is that the help message is wrong, the correct variables are $client_number and $client_id_number.

@david can you please confirm that’s correct?

david · February 15, 2021, 8:25pm

correct, $client_number and $client_id_number

peterjm · February 15, 2021, 9:21pm

ok but i cant get client_counter to work with any combination of:
a) client_number
b) client_id_number
or c) client_number and client_id_number

When i first noticed this i was using the exact same variables as i did in 5.0.47-c38. I think something changed and broke in the error checking?

hillel · February 15, 2021, 9:40pm

This bug should be fixed in the next release

peterjm · February 19, 2021, 4:39am

Confirmed problem is fixed when i tested on v5.1.6-C42

Thank you!

hillel · February 19, 2021, 5:23am

Thanks for the update!

cdahinten · February 19, 2021, 1:44pm

Hello @hillel,

I have upgarded to 5.1.7 v5-stable today and can not confirm it is working:

Shouldn’t the TETO-Numbers start with TETO_0001, when $client_counter is used?

Do you have any idea, why?

hillel · February 19, 2021, 1:54pm

Thanks for reporting this, @david any ideas?

cdahinten · February 19, 2021, 2:58pm

I made git clone of the project and reinstalled v5.1.7-C42 again with artisan optimize an fresh company. The counter still counts up gloabally an not per client. Is there a artisan command to prevent any cached behaviour from previuos 5.1.4 or 5.1.6?

cdahinten · February 19, 2021, 3:14pm

Hello @hillel, hello @david, I was wondering why the client_counter did not work on my installation, even it was confirmed workig. I found the reason: service nginx reload. Now I can confirm everything is working as inteded. Thank you and excuse caused confusion.